Add Pre-Commit Hooks Required Cargo Deps #752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying contributing-docs with
|
| Latest commit: |
cd72d86
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://dcbc270c.contributing-docs.pages.dev |
| Branch Preview URL: | https://rustprecommithooksdeps.contributing-docs.pages.dev |
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
neuronull
reviewed
Jan 16, 2026
|
|
||
| - Visual C++ Build tools | ||
| - [Rust](https://www.rust-lang.org/tools/install) | ||
| - Cargo binaries for pre-commit hooks |
Contributor
There was a problem hiding this comment.
We should also specify that nightly is required. for the toolchain. We can take inspiration from https://github.com/bitwarden/sdk-internal?tab=readme-ov-file#installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
No ticket
📔 Objective
Add dependencies for required cargo binaries for pre-commit hooks. These were added in this PR: bitwarden/clients#17823